Skip to content

Cleanup ftue code and ensure verification confirmation is displayed #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2025
Merged

Cleanup ftue code and ensure verification confirmation is displayed #5379

merged 3 commits into from
Sep 22, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 19, 2025

Content

Rework the FTUE code.
Ensure that the verification confirmation screen is displayed.
It could happen that this screen was not displayed in the case of the session verification was the last FTUE step to complete.

It will also help for the multi account feature.

Motivation and context

Code a bit more readable and fix an issue.

Screenshots / GIFs

No expected change

Tests

  • Login to an account
  • Ensure that all the Ftue steps are displayed and can be completed.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner September 19, 2025 16:39
@bmarty bmarty requested review from jmartinesp and removed request for a team September 19, 2025 16:39
@bmarty bmarty added the PR-Bugfix For bug fix label Sep 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7P2GNk

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.37%. Comparing base (5c893e7) to head (dcec958).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/features/ftue/impl/state/DefaultFtueService.kt 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5379   +/-   ##
========================================
  Coverage    80.37%   80.37%           
========================================
  Files         2275     2276    +1     
  Lines        62884    62895   +11     
  Branches      7869     7872    +3     
========================================
+ Hits         50542    50551    +9     
- Misses        9436     9437    +1     
- Partials      2906     2907    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty force-pushed the feature/bma/cleanupFtueCode branch from b7dc878 to f9d8c9a Compare September 19, 2025 16:51
@bmarty
Simplify the code again.
dcec958 
We do not need `isVerificationStatusKnown`. If `sessionVerificationService.sessionVerifiedStatus` is `Unknown`, `isSessionVerificationStateReady()` will return true and `isSessionNotVerified()` will not be called, since the `ftueState` will be `FtueStep.WaitingForInitialState`.

Note that TU is still OK with this change.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jmartinesp
jmartinesp approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit c646d6d into develop Sep 22, 2025
30 of 31 checks passed
@bmarty bmarty deleted the feature/bma/cleanupFtueCode branch September 22, 2025 09:13
@bmarty bmarty mentioned this pull request Sep 22, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Bugfix For bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @jmartinesp